Form object refactoring #11905
Merged
Form object refactoring #11905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
together with migration that will create the columns and migrates data from lead_field column. I cleaned the entity a bit too. It was full of verbose syntax, strings over constants and comments that did not bring any value.
by not extending FormTestAbstract And shorter syntax is used to create mocks
plus removing inheritance from tests, stop booting kernel for unit tests, speeding up tests by 3 seconds.
RCheesley
added
the
pending-test-confirmation
mabumusa1
previously approved these changes
Feb 4, 2023
RCheesley
added
ready-to-commit
|
RTC assuming the comments from @escopecz on the code review are satisfied, which it looks like they are. |
volha-pivavarchyk
dismissed stale reviews from mabumusa1 and RCheesley
via
d5a9620
|
@RCheesley @escopecz @mabumusa1 I removed the commented code that was unnecessary. This code is not used and shouldn't affect anything. Could you please test and re-approve it again. |
mabumusa1
approved these changes
Feb 8, 2023
|
Thanks for all the testing folks, will commit this once the tests complete! 🚀 |
RCheesley
added
forms
JoshuaEstes
added a commit
to JoshuaEstes/mautic
that referenced
this pull request
Feb 8, 2023
* upstream/5.x: TPROD-334 - MauticCrmBundle - Migrate PHP Templates to Twig (mautic#11936) TPROD-333 - MauticClearbitBundle - Convert PHP Templates to Twig Templates (mautic#11937) Form object refactoring (mautic#11905) docs: add volha-pivavarchyk as a contributor for code (mautic#11940) quick smoke test TPROD-321 - NotificationBundle - Popup
JoshuaEstes
added a commit
to JoshuaEstes/mautic
that referenced
this pull request
Feb 8, 2023
… import/TPROD-319 * 'import/TPROD-319' of github.com:JoshuaEstes/mautic: (33 commits) TPROD-334 - MauticCrmBundle - Migrate PHP Templates to Twig (mautic#11936) TPROD-333 - MauticClearbitBundle - Convert PHP Templates to Twig Templates (mautic#11937) Form object refactoring (mautic#11905) docs: add volha-pivavarchyk as a contributor for code (mautic#11940) finish templates TPROD-232 - MauticFullContactBundle - Convert PHP Templates to Twig Templates twig lint builder works test check check checkpoint categorylist slot bug fix, cleanup html validation form theme form theme template cleanup cleanup make sure builder uses twig templates instead of php ...
JoshuaEstes
added a commit
to JoshuaEstes/mautic
that referenced
this pull request
Feb 9, 2023
* upstream/5.x: (37 commits) TPROD-334 - MauticCrmBundle - Migrate PHP Templates to Twig (mautic#11936) TPROD-333 - MauticClearbitBundle - Convert PHP Templates to Twig Templates (mautic#11937) Form object refactoring (mautic#11905) docs: add volha-pivavarchyk as a contributor for code (mautic#11940) All contributors/add lord rembo (mautic#11935) finish templates TPROD-232 - MauticFullContactBundle - Convert PHP Templates to Twig Templates Update UPGRADE-PHP-TO-TWIG-TEMPLATES.md (mautic#11921) twig lint builder works test check check checkpoint categorylist slot bug fix, cleanup TPROD-319 - LeadBundle - Custom Fields Templates (mautic#11819) html validation form theme form theme template ...
|
This pull request has been mentioned on Mautic Forums. There might be relevant details there: |
|
This pull request has been mentioned on Mautic Forums. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR replaces PR #11234: rebased and errors fixes
Steps to test this PR:
Open mautic/mautic on Gitpod or pull down for testing locally (see docs on testing PRs here) - as you need to do some things before applying the PR.
Before you checkout this PR:
Create a form with at least 4 fields. One mapped to the contact email field, one mapped to the company field under the contact opt group, one mapped to the primary company city field. The fourth field should not be mapped to any field.
Check out this PR - in Gitpod on the left hand side, look for the Github icon, then find this PR and right click to checkout the PR:
Run the migration using the terminal tab.
Run
ddev exec bin/console doctrine:migrations:execute --up 20200415135706. Note: you can roll back your changes withddev exec bin/console doctrine:migrations:execute --down 20200415135706if needed.Open PHPMyAdmin under the Ports tab on Gitpod, look for the port 8036. Open it in a tab.
Open the database named 'db' and go to the
form_fieldstable and check that the last 2 columns aremapped_objectandmapped_field. The field that was mapped to the contact email field should havemapped_object = 'lead'andmapped_field = 'email'. The one that was mapped to the company field under the contact opt group should havemapped_object = 'lead'andmapped_field = 'company'. The one that was mapped to the primary company city field should havemapped_object = 'company'andmapped_field = 'companycity'. The form field that was not mapped at all should have null values there.When you map one field then it should be removed from mapping of other fields. Example: Map contact email field to a form field. Create another field. The contact email field is not in the mapping list.
Test submissions of different field types.
Test conditional fields
Test progressive profiling (behaviours)
List deprecations along with the new alternative:
form_fields.lead_fieldcolumn is deprecated. Usemapped_objectandmapped_fieldinstead.Mautic\FormBundle\Entity\Field::getLeadField()andsetLeadField(). Use getters and setters onmappedObjectandmappedFieldproperties instead.Mautic\FormBundle\Event\Service\FieldValueTransformer::isIsTransformed()is deprecated as not used.